feat(dom): DOM - toHaveClass , toHaveAllClasses and toHaveAnyClass #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fonsiher
force-pushed
the
feat/dom-have-class
branch
from
6827334 to
18f9d98
Compare
ChristianSama
approved these changes
Oct 18, 2024
JoseLion
reviewed
Oct 24, 2024
| * - `exact` (boolean): When true, checks for an exact match of all classes. | ||
| * @returns the assertion instance. | ||
| */ | ||
| public toHaveClass(classNames: string | string[], options: { exact?: boolean; } = {}): this { |
There was a problem hiding this comment.
What do you think about making more than one assertion instead of adding the options param? To me, it'll provide more readability if we have the following:
expect(elem).toHaveClass("w-full"); // single arg
expect(elem).toHaveAnyClass("w-full", "flex"); // variadic args
expect(elem).toHaveAllClasses("w-full", "flex", "gap-8"); // variadic argsThere was a problem hiding this comment.
Thanks @JoseLion this is actually a great idea to improve readability. I just added these new matches.
fonsiher
force-pushed
the
feat/dom-have-class
branch
2 times, most recently
from
6e6062d to
a831c90
Compare
fonsiher
requested review from
kdquistanchala,
KevinJ1998 and
JoseLion
and removed request for
matycarolina
suany0805
approved these changes
Apr 23, 2025
JoseLion
reviewed
Apr 24, 2025
fonsiher
changed the title
fonsiher
force-pushed
the
feat/dom-have-class
branch
from
a831c90 to
8805f6f
Compare
fonsiher
changed the title
fonsiher
force-pushed
the
feat/dom-have-class
branch
from
0d3c0c6 to
e512c76
Compare
|
Thanks for your review @JoseLion , you're right, I've added the prop to the testing function and now are using getByText for render the element for Testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the toHaveClass matcher.